refactor(hydroflow_plus)!: defer network instantiation until after finalizing IR #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
12f8012
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8204a12.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1377.hydroflow.pages.dev |
shadaj
force-pushed
the
pr1377
branch
9 times, most recently
from
58321d4
to
800ecc0
Compare
MingweiSamuel
approved these changes
Aug 14, 2024
Comment on lines
+44
to
+47
| pub enum DebugInstantiate<'a> { | ||
| Building(Box<dyn Fn() -> BuildingOut<'a> + 'a>), | ||
| Finalized(syn::Expr, syn::Expr, Rc<dyn Fn() + 'a>), | ||
| } |
There was a problem hiding this comment.
I guess all the added lifetimes trickle down to this one spot?
There was a problem hiding this comment.
Yep, will look into eliminating this eventually...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.